Skip to content

chore(deps): bump golang.org/x/crypto from 0.31.0 to 0.35.0 to fix CVE-2025-22869 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

ranakan19
Copy link
Contributor

@ranakan19 ranakan19 commented Apr 4, 2025

What type of PR is this?

/kind bug

What does this PR do / why we need it:
fixes CVE-2025-22869, note that the new version of golang/x/crypto needs golang to be upgraded to 1.23
Changes:

  • Updates golang/x/crypto from 0.31.0 to 0.35.0
  • Update golang to 1.23
  • Update github action checkout to v4
  • Update github action setup-go to v5
  • Use go-version-file with setup-go to pick up go version from go.mod instead of hardcoding

Have you updated the necessary documentation?
N/A

Which issue(s) this PR fixes:
N/A

Signed-off-by: Kanika Rana <[email protected]>
Copy link

openshift-ci bot commented Apr 4, 2025

@ranakan19: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug

What does this PR do / why we need it:
fixes CVE-2025-22869, note that the new version of golang/x/crypto needs golang to be upgraded to 1.23
Changes:
Updates golang/x/crypto from 0.31.0 to 0.35.0
Update golang to 1.23
Update github action checkout to v4
Update github action setup-go to v5
Use go-version-file with setup-go to pick up go version from go.mod instead of hardcoding
Disable HTTP/2 by default on the server

Have you updated the necessary documentation?
N/A

Which issue(s) this PR fixes:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from jopit and keithchong April 4, 2025 02:41
Copy link

openshift-ci bot commented Apr 4, 2025

Hi @ranakan19. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Kanika Rana <[email protected]>
@anandf
Copy link
Member

anandf commented Apr 10, 2025

/ok-to-test

@jannfis
Copy link
Member

jannfis commented Apr 15, 2025

/retest

@jannfis
Copy link
Member

jannfis commented Apr 16, 2025

/ok-to-test

@jannfis
Copy link
Member

jannfis commented Apr 16, 2025

/lgtm

@chetan-rns
Copy link
Member

/test v4.13-e2e

@svghadi
Copy link
Member

svghadi commented Apr 16, 2025

/ok-to-test

@chetan-rns
Copy link
Member

/approve

Copy link

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chetan-rns
Copy link
Member

/ok-to-test

@keithchong
Copy link
Collaborator

/ok-to-test

@openshift-merge-bot openshift-merge-bot bot merged commit 14be804 into redhat-developer:master Apr 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants